search

meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
91 stars 90 forks source link

feat: Add validation of preventing signing up from anonymous mail domains #125

Closed codingmickey closed 11 months ago

codingmickey commented 12 months ago

Notes for Reviewers

Blocking signing up from the following domains:

The list can be expanded in the future by just adding more domains in this regex

https://github.com/codingmickey/play/blob/e809dcefef7a10c3d3c7e93f473d78e0be3a310a/site/src/components/SignupForm/index.js#L19

This PR fixes #123

If any changes are required do let me know!

Signed commits

netlify[bot] commented 12 months ago

Deploy Preview for meshery-play failed.

Name Link
Latest commit 93621d85e7b81cd4fb0c93d86fa68a303a216912
Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/64b5be4d84edcd000896bc96
leecalcote commented 11 months ago

@codingmickey will you confirm that mutli-word first and last names, whether with whitespace or hyphenations is allowed?

leecalcote commented 11 months ago

I'm removing other reviewers, who have yet to offer feedback.

leecalcote commented 11 months ago

@codingmickey Build failure:

5:19:29 PM: src/components/SignupForm/index.js
5:19:29 PM:   Line 50:9:  'errorRole' is assigned a value but never used                                                                                                                                                                                   no-unused-vars
5:19:29 PM:   Line 66:6:  React Hook useEffect has a missing dependency: 'onSubmit'. Either include it or remove the dependency array. If 'onSubmit' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps
codingmickey commented 11 months ago

@codingmickey thanks for this. Will you please address the other concern regarding multi-word names?

Sure I can work upon that..

Will you ensure that the layer5.io forms follow this same approach?

Aye aye

codingmickey commented 11 months ago

@codingmickey Build failure:

5:19:29 PM: src/components/SignupForm/index.js
5:19:29 PM:   Line 50:9:  'errorRole' is assigned a value but never used                                                                                                                                                                                   no-unused-vars
5:19:29 PM:   Line 66:6:  React Hook useEffect has a missing dependency: 'onSubmit'. Either include it or remove the dependency array. If 'onSubmit' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

Oops these didn't occur on my local, sorry about it.. will update and make a new pr

leecalcote commented 11 months ago

@codingmickey will you consider an update to support this special character issue in the registration forms? - ā