search

meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
98 stars 100 forks source link

replace signup form with modal #219

Closed vishalvivekm closed 3 weeks ago

vishalvivekm commented 3 weeks ago

Notes for Reviewers

This PR fixes #214

Signed commits

netlify[bot] commented 3 weeks ago

Deploy Preview for meshery-play ready!

Name Link
Latest commit 313477de5f598cc40959041f421d85f2f445c324
Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/671652929802eb0008dec1a1
Deploy Preview https://deploy-preview-219--meshery-play.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vishalvivekm commented 3 weeks ago

image

vishalvivekm commented 3 weeks ago

Thank you @hargunkaur286 I'll address these.

vishalvivekm commented 3 weeks ago

@hargunkaur286 "Join the community" and Discuss calll out: image

any suggestions?

vishalvivekm commented 3 weeks ago

fixed :-

  1. Can we also keep this discussion forum box
  2. The video preview image is not visible
  3. White colour text on yellow background I think do not go well together. Instead, can we keep the text colour as "black"?