meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
98 stars 98 forks source link

Made Signup form responsive for smaller devices #34

Closed akssshh closed 1 year ago

akssshh commented 1 year ago

Description Signed-off-by: AkashGogoi gogoiakash09@gmail.com

This PR fixes #28

Notes for Reviewers

Signed commits

netlify[bot] commented 1 year ago

Deploy Preview for meshery-play ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/638467a48f98a11f35c6c370
Deploy Preview https://deploy-preview-34--meshery-play.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

leecalcote commented 1 year ago

Good. Does this PR replace https://github.com/meshery/play/pull/31? Should https://github.com/meshery/play/pull/31 be closed?

leecalcote commented 1 year ago

@gogoiakash2311 follow these instructions to sign your commits - https://github.com/meshery/play/pull/34/checks?check_run_id=9715429720

leecalcote commented 1 year ago

@gogoiakash2311, follow these instructions to configure your system to always sign your commits, so that you don't have to worry about it any more and so that maintainers don't have to remind you to do this each time. 😉 - - https://github.com/meshery/play/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin

akssshh commented 1 year ago

Good. Does this PR replace #31? Should #31 be closed?

Yes #31 should be closed

akssshh commented 1 year ago

@gogoiakash2311, follow these instructions to configure your system to allows sign your commits, so that you don't have to worry about it any more and so that maintainers don't have to remind you to do this each time. 😉 - - https://github.com/meshery/play/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin

I forgot to sign-off my commits. I'll follow the instructions

leecalcote commented 1 year ago

@gogoiakash2311, follow these instructions to configure your system to allows sign your commits, so that you don't have to worry about it any more and so that maintainers don't have to remind you to do this each time. 😉 - - https://github.com/meshery/play/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin

I forgot to sign-off my commits. I'll follow the instructions

Sounds great. No sweat. 👍

akssshh commented 1 year ago

Thanks, @leecalcote for the guidance. Done with the sign-off commits.