search

meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
91 stars 90 forks source link

Added promo video with banner img as thumbnail #63

Closed Nikhil-Ladha closed 1 year ago

Nikhil-Ladha commented 1 year ago

Signed-off-by: Nikhil-Ladha nikhilladha1999@gmail.com

Description: Added the promo video with the current screenshot as the thumbnail using the react-player package. Also, retained the styles to the banner :)

This PR fixes #61

Signed commits

netlify[bot] commented 1 year ago

Deploy Preview for meshery-play ready!

Name Link
Latest commit d39f46438c9d0ad911f1807138bcfed19069e01e
Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/63d2e09b9d650f000ac423a6
Deploy Preview https://deploy-preview-63--meshery-play.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

leecalcote commented 1 year ago

No you didn't... Ha! Yes, you did. Oh, that is very cool how you retained the banner styles behind the video. 😁

leecalcote commented 1 year ago

I wonder if there's a way that we might make the play triangle catch the visitor's eye a little more than is does now.

leecalcote commented 1 year ago

Or maybe if there were a bit of an onHover effect (outside of the pointer) on the banner.

Nikhil-Ladha commented 1 year ago

Or maybe if there were a bit of an onHover effect (outside of the pointer) on the banner.

Probably, we could do both. Let me see...

Nikhil-Ladha commented 1 year ago

How about now? 👀

Nikhil-Ladha commented 1 year ago

Merging it, considering the priority of it. If any change is needed, let me know :)

leecalcote commented 1 year ago

Thank you, thank you. 👏