search

meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
98 stars 98 forks source link

[Site] Update navbar for mobile screens #64

Closed Avi-88 closed 1 year ago

Avi-88 commented 1 year ago

Current Behavior

Currently the navbar remains same throughout all screen sizes and looks a bit cramped for smaller screens. dark-old

Desired Behavior

For screens below 500px the navbar will have a sort of hamburger menu.

dark-new-open

Implementation

I was thinking about moving the entire navbar into its own navigation component. While the theme state will remain in app.js we can use props to pass and change its value from inside navigation component. If there is any other approach to this please let me know.

Mockups

light-new-nav light-new-open

Contributor Guide

Avi-88 commented 1 year ago

Hi @leecalcote , sorry for the delay. Can you please share your thoughts on this and assign me this issue as well. I'll start working on the PR, thanks

leecalcote commented 1 year ago

Good work on the proposal and on the quality of these mockups, @Avi-88.

@Nikhil-Ladha, here’s a proposal for your consideration.

Yh010 commented 1 year ago

can i also work on this issue along with @Avi-88 ?

Avi-88 commented 1 year ago

Hi @Yh010 , I'm actually done with the changes that I proposed in the mockups currently waiting for the proposal to get accepted so i can make a PR. If you have a different design in mind I would be happy to help in making a new proposal, thanks

Avi-88 commented 1 year ago

Hi @Yh010 , I was suggesting you to make a proposal with mockups having a different approach than the one I proposed as it will be easier to review the proposal and finalize a approach. I dont know exactly what happened but your PR seems to have multiple duplicate file changes. It would be better if you could link a PR that specifies the approach you are suggesting along with some mockups of the actual design, thanks