Closed roopeshsn closed 1 year ago
Name | Link |
---|---|
Latest commit | 577655078089c7da15cd34ce48b20842f5b049b8 |
Latest deploy log | https://app.netlify.com/sites/meshery-play/deploys/63fdb554cc70210008b14904 |
Deploy Preview | https://deploy-preview-68--meshery-play.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Was this presented on today’s meeting? If so, what feedback was given?
@Avi-88 offer a review?
@Avi-88 offer a review?
Yeah, sure.
Good feedback. Thanks, @Avi-88.
@roopeshsn one-time DCO instructions for this PR: https://github.com/meshery/play/pull/68/checks?check_run_id=11467125472
Instructions for a permanent fix to always signing your commits: see the contributing.md.
Was this presented on today’s meeting? If so, what feedback was given?
Yes, Lee! The PR was presented on that day. The issue is the drop-down icon is not visible in light mode. Let me fix the Netlify preview.
Thanks, @Avi-88 for the review. I will make the changes accordingly.
All good now, but the preview fails again.
All good now, but the preview fails again.
I'm guessing that is because it detected no change from the last build cache, try pushing a new commit with the change I suggested. It might trigger the pipeline for this one
All good now! Here's the deploy preview: https://deploy-preview-68--meshery-play.netlify.app/
Thanks, @Avi-88 for the help!
Notes for Reviewers Added FAQ section.
This PR fixes #67
Signed commits