meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
91 stars 90 forks source link

feat: Faq section #68

Closed roopeshsn closed 1 year ago

roopeshsn commented 1 year ago

Notes for Reviewers Added FAQ section.

This PR fixes #67

Signed commits

netlify[bot] commented 1 year ago

Deploy Preview for meshery-play ready!

Name Link
Latest commit 577655078089c7da15cd34ce48b20842f5b049b8
Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/63fdb554cc70210008b14904
Deploy Preview https://deploy-preview-68--meshery-play.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

leecalcote commented 1 year ago

Was this presented on today’s meeting? If so, what feedback was given?

leecalcote commented 1 year ago

@Avi-88 offer a review?

Avi-88 commented 1 year ago

@Avi-88 offer a review?

Yeah, sure.

leecalcote commented 1 year ago

Good feedback. Thanks, @Avi-88.

@roopeshsn one-time DCO instructions for this PR: https://github.com/meshery/play/pull/68/checks?check_run_id=11467125472

Instructions for a permanent fix to always signing your commits: see the contributing.md.

roopeshsn commented 1 year ago

Was this presented on today’s meeting? If so, what feedback was given?

Yes, Lee! The PR was presented on that day. The issue is the drop-down icon is not visible in light mode. Let me fix the Netlify preview.

roopeshsn commented 1 year ago

Thanks, @Avi-88 for the review. I will make the changes accordingly.

roopeshsn commented 1 year ago

All good now, but the preview fails again.

Avi-88 commented 1 year ago

All good now, but the preview fails again.

I'm guessing that is because it detected no change from the last build cache, try pushing a new commit with the change I suggested. It might trigger the pipeline for this one

roopeshsn commented 1 year ago

All good now! Here's the deploy preview: https://deploy-preview-68--meshery-play.netlify.app/

roopeshsn commented 1 year ago

Thanks, @Avi-88 for the help!