Closed sidtohan closed 1 year ago
@Avi-88 can you please have a look at this whenever possible? Thanks.
Name | Link |
---|---|
Latest commit | fa7656394294b84836c31329e3832630875d1594 |
Latest deploy log | https://app.netlify.com/sites/meshery-play/deploys/63fd7efe2fa6480008443537 |
Deploy Preview | https://deploy-preview-74--meshery-play.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Hi @sidtohan , good job on the changes. Think of this as a add on to your changes, so I was thinking about adding a little box shadow on hover for the buttons, kinda like a glow effect as the current effects are not that prominent, do let me know what you think about that. If you have any other suggestion in mind please feel free to share it too, thanks
@Avi-88 that's a great idea. Other than that i don't think anything else is needed, it's best if the effects are subtle.
I'll get to work on the box shadows. Thanks.
@Avi-88 I have done the required changes. If there are any further improvements that can be made, please kindly tell. Thanks.
If it's all good, can it be merged? There's another issue I'd like to work on in this repo. Thanks. @leecalcote @Avi-88
Don't worry about it @sidtohan , your PR will get merged once the final approving review is done. It might take some time as there are many other PR's to go through as well. Just so you know , if any of your PR goes unnoticed for too long you can just ping it in slack or bring it up in the weekly dev call. As for the other issue, you can continue working on it. No need to wait for this to be merged , just remember to check on this if it's been far too long , thanks
I see. @Avi-88 thanks a lot for your guidance.
@sidtohan Good stuff here, just a minor to look the bottom border is getting cut here. Will you make a fix for this?
Alright sure I'll look into this.
@Chadha93 I have fixed the issue. Kindly take a look whenever possible. Thanks.
This is a follow up to the issue raised regarding lack of transition effects on buttons. Notes for Reviewers
This PR fixes #73
Signed commits