meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
98 stars 98 forks source link

Remove login icon from React player alternate image and make padding consistent #75

Closed vishnus17 closed 1 year ago

vishnus17 commented 1 year ago

Current Behavior

  1. There is a login button inside the image displayed for the React player which is misleading.

    image
  2. Padding is inconsistent between the React player and the text above and below it

    image

Desired Behavior

  1. Removing the login icon.
  2. Adding 3rem as margin-top for caption element similar to the other elements to make it consistent.

Implementation

  1. Fix for issue 1

    image
  2. Fix for issue 2

    image

Acceptance Tests

Mockups


Contributor Guide

vishnus17 commented 1 year ago

Hi. If you feel this needs a fix, I have it ready and I can submit the PR.

leecalcote commented 1 year ago

Thanks, @vishnus17. Please ensure that no image quality is lost as you edit the thumbnail.

leecalcote commented 1 year ago

here is the original Figma design - https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI?node-id=4199%3A21678&t=p40GR93P9GDgeX6o-4

vishnus17 commented 1 year ago

@leecalcote . I've requested access. I used canva to add a rectangle on the thumbnail png which I got from the assets folder. The image quality seems to be intact. Shall I submit the PR so that you can review it from the preview?

leecalcote commented 1 year ago

Access granted. Yes, sounds good. I'm hailing @Avi-88 and @Yashsharma1911 as folks that will review.

vishnus17 commented 1 year ago

Here's the preview link: https://deploy-preview-76--meshery-play.netlify.app