meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
98 stars 98 forks source link

Updated RegEx #82

Closed BabyElias closed 1 year ago

BabyElias commented 1 year ago

Notes for Reviewers

This PR fixes #79

Signed commits

netlify[bot] commented 1 year ago

Deploy Preview for meshery-play ready!

Name Link
Latest commit 39255d3de483935c6431b67f83398183488f2d42
Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/6409e4f09d81620008e1023f
Deploy Preview https://deploy-preview-82--meshery-play.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Avi-88 commented 1 year ago

Hi @BabyElias , the regex you proposed allows numbers as well as white space though. Also the same regex needs to be applied to last name input as well

BabyElias commented 1 year ago

Hi @BabyElias , the regex you proposed allows numbers as well as white space though. Also the same regex needs to be applied to last name input as well

I tested it for numbers and whitespace, it doesn't accept them as answers.

BabyElias commented 1 year ago

Some checks : Used numbers image Used whitespace image Accepts accented characters. image

Avi-88 commented 1 year ago

Ohh, hmm thats weird. Well if there isn't any problem then awesome. Also add the same to the last name as well, you never know Shaquille O'Neal might wanna sign up 👀

BabyElias commented 1 year ago

Ohh, hmm thats weird. Well if there isn't any problem then awesome. Also add the same to the last name as well, you never know Shaquille O'Neal might wanna sign up 👀

Ohkay, Sure!

BabyElias commented 1 year ago

@Avi-88 The name field doesn't allow for apostrophes, is that a problem?

Avi-88 commented 1 year ago

@Avi-88 The name field doesn't allow for apostrophes, is that a problem?

Umm Kinda, I mean we are doing this to be inclusive of different names. I dont think it'll be that difficult to make it happen. could you please give it a try, the regex I provided earlier might help , thanks

Avi-88 commented 1 year ago

@BabyElias , I think there's some issue. Also good work so far , I know this is just going back and forth but we do need to test as much as possible ,hang in there you almost got it image

BabyElias commented 1 year ago

Yup, I'll check and let you know once the changes are done.

BabyElias commented 1 year ago

@Avi-88 Done with changes pertaining to making the regex more inclusive