meshery / play

Cloud Native Playground for Kubernetes and all CNCF projects
https://play.meshery.io
Apache License 2.0
91 stars 90 forks source link

Replace the Logo of Layer5 with Meshery in config.yml workflow #93

Closed anshgoyalevil closed 1 year ago

anshgoyalevil commented 1 year ago

Description

Currently, we are using the Logo of Layer5 instead of Meshery. This repository is under the organization Meshery, so, there should be the image of Meshery.

How to resolve this?

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Meshery Logo" src="">
</picture>

New images are:

Meshery-celebration-Light Meshery-celebration-Dark

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:

  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
  &nbsp; &#9; &nbsp; &#9;  &nbsp; &#9;  &nbsp; &#9; :star: Please leave a [star on the project](../stargazers). :smile:

Here, replace ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png) with the code

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

make sure to change the image sources with the path to image in the folder where you upload it.


Contributor Guides and Handbook

Saksham294 commented 1 year ago

Hey can I work on this?

leecalcote commented 1 year ago

@anshgoyalevil, never store images like this outside of the repo. They must be stored inside of .github. @goldfishdolphin help, help.

anshgoyalevil commented 1 year ago

@leecalcote

Actually, I was previously testing this Raw SVG thing, so used the same srcset instead of images stored inside the repo.

Made a PR fixing that thing. Apologies.

vishalvivekm commented 1 year ago

@anshgoyalevil // @goldfishdolphin Guys, some of the points that you should take special care of while changing the logos in the readme or the workflows:

  1. all images for the readme/workflow-logos should be under .github somewhere, not in other repos or in other folders in the same repo.
  2. make sure they support both dark mode and light mode
  3. Please also ensure correct image size and margins around them i.e, there' shouldn't be this much spacing that's there in the meshery/meshery-nginx-sm Readme.md // meshery/meshery-nginx-sm/pull/224
anshgoyalevil commented 1 year ago

@vishalvivekm

Thanks for giving the suggestions Sir. Will keep them in mind for future.

ankur0904 commented 1 year ago

Can I work on this issue?