feat: add type as first class attribute in relationship definition

meshery / schemas

Logical object models for Meshery

Apache License 2.0

9 stars 16 forks source link

Closed MUzairS15 closed 3 months ago

MUzairS15 commented 3 months ago

Notes for Reviewers

This PR fixes #

MUzairS15 commented 3 months ago

@leecalcote As this gets merged we should make a release with v1beta1 tag?

leecalcote commented 3 months ago

@MUzairS15, knowing that we're going to make larger modifications soon, ideally, those are included in the v1beta1.

Releasing a v1alpha2 might make more sense now.

leecalcote commented 3 months ago

There's an open PR that deletes the failing (and inappropriate) eslint-check / runner / eslint (pull_request) workflow.

MUzairS15 commented 3 months ago

That's merged, I wonder why I don't see option for Update Branch (sync with master) might be some settings update needed.

leecalcote commented 3 months ago

LGTM