Hi, this is a cool library and as I looked at some of the examples in the readme, I had the following suggestions to make.
Remove show=show from the examples as it is not the correct syntax for showing the mesh. show=True does work, but produces many plots of the mesh as it is being generated (too many for my liking).
There is some nice built-in plotting functionality, so I added a line to the first example code block to demonstrate how a plot of the mesh can be generated.
Anyway, this and your other mesh libraries are super cool, so thank you for all of the open source development that you do! Hope you find this PR to be reasonable.
nschloe
commented
4 years ago
Hi, this is a cool library and as I looked at some of the examples in the readme, I had the following suggestions to make.
Remove
show=showfrom the examples as it is not the correct syntax for showing the mesh.show=Truedoes work, but produces many plots of the mesh as it is being generated (too many for my liking).There is some nice built-in plotting functionality, so I added a line to the first example code block to demonstrate how a plot of the mesh can be generated.
Anyway, this and your other mesh libraries are super cool, so thank you for all of the open source development that you do! Hope you find this PR to be reasonable.