meshpro / meshzoo

A collection of meshes for canonical domains
326 stars 40 forks source link

Icosasphere refinement #55

Closed alexj94 closed 4 years ago

alexj94 commented 4 years ago

Hi, I recently installed your library and used the computed geometries with some differentiable renderers in a 3D object generation pipeline. In particular, I'm interested in the icosasphere as a symmetrical shape. The problem is that the rendered shape is actually an icosahedron with no refinement to obtain an icosasphere. Do you plan to add this refinement operation or have any idea on how to do it correctly?

nschloe commented 4 years ago

The only argument to the method is a refinement parameter.

alexj94 commented 4 years ago

I know but the resulting geometry is not spherical after the rendering. I'm using two different renderers and each one obtains the same geometry that is more similar to an icosahedron than an icosasphere as in the README file. I give you two rendered examples (the first using Neural Mesh Renderer and the second using DIB-Renderer) using an icosasphere with n=8 just to know if the output is actually correct or not. shape example

nschloe commented 4 years ago

Good catch! I'll fix that right away and add tests.

nschloe commented 4 years ago

Fixed now. Thanks again for the report.

alexj94 commented 4 years ago

Yes thanks for the quick correction. I confirm that now it works fine with both renderers. shape example