search

meshtastic / ATAK-Plugin

ATAK Plugin for sending CoT to IMeshService
GNU General Public License v3.0
168 stars 19 forks source link

[Question] Rationale to revert back to previous file naming convention? #18

Closed mtsdawson closed 7 months ago

mtsdawson commented 7 months ago

The 4.10.0 in the filename has created some confusion with users as it suggests a unique fork for the legacy ATAK version. This appeared to be resolved with v1.0.11 as shows v5.0.0 in the filename.

What's the rationale to revert back to the v4.1 designation in the filename? Any chance this can be removed entirely to reflect cross-version compatibility?

Filenames: ATAK-Plugin-Meshtastic.Plugin-1.0.12-d77f5b26-4.10.0-civ-release.apk ATAK-Plugin-Meshtastic.Plugin-1.0.11-4ac447bb-5.0.0-civ-release.apk

Thanks for the great work on this plugin.

niccellular commented 7 months ago

when you submit the source code to TPC for building, they name the file as plugin version, git hash, atak version.

prior to atak 4.10, plugins had to be recompiled for the particular atak version.

4.10+ plugins can now run on 4.10, 5.0, 5.1 etc

mtsdawson commented 7 months ago

Correct, therefore would it be possible to either A) remove 4.10 from the filename, or B) change it to 5.0.0 as you did in the previous build?

I get a lot of noise from users hesitant to install this plugin when it lists v4.10 in the APK filename.

niccellular commented 7 months ago

tell them 4.10 plugins work on 5.x