search

meshtastic / Meshtastic-Android

Android application for Meshtastic
https://meshtastic.org
GNU General Public License v3.0
675 stars 195 forks source link

[Feature Request]: Rearrange traceroute result and add some differentiating colour #1207

Open b8b8 opened 3 weeks ago

b8b8 commented 3 weeks ago

Contact Details

No response

Tell us your idea.

My suggestion is to have the traceroutes present vertically and with different colours for hops, transmit, and receive. Also including the hopping SNR would be beneficial. signal-2024-08-24-144701

Relevant log output

No response

Code of Conduct

GUVWAF commented 3 weeks ago

Hey @b8b8, maybe it would be good to consider here how traceroute in 2.5 is going to look like in general. Apart from the SNR per hop, we can also get a two-way traceroute result. There is some validation needed, because it depends on the firmware of the nodes in the route whether the info is accurate or not. I opened a PR for the Python CLI (https://github.com/meshtastic/python/pull/654) to accommodate for this; basically the length of the list of SNRs should be 1 longer than the route list and nodes and SNR can be unknown (represented by 0xFFFFFFFF and -128 respectively).

Maybe it can look something like this then (excuse me for my Paint skills): traceroute_android

Not sure how feasible all of this is, but it would be cool to show it like this :)

b8b8 commented 3 weeks ago

Dude this looks even better.

cbvicious commented 3 weeks ago

Is there any possibility to add timestamps to each hop? And/or how many attempts it took to make each hop? Could be useful for assessing where you need better coverage.

Nestpebble commented 3 weeks ago

I've already mentioned it in the discord, but apparently not asked for it as a feature request. Putting the results in the chat history for a node would solve some of the things people have asked for above

b8b8 commented 3 weeks ago

I've already mentioned it in the discord, but apparently not asked for it as a feature request. Putting the results in the chat history for a node would solve some of the things people have asked for above

yea, how about the pop-up, but then also the pop-up results end up saved in the appropriate DM with text of all the info people are asking for. Pop just shows info GUVWAF posted. DM has all this plus any other info like timing as text.

Nestpebble commented 3 weeks ago

I've already mentioned it in the discord, but apparently not asked for it as a feature request. Putting the results in the chat history for a node would solve some of the things people have asked for above

yea, how about the pop-up, but then also the pop-up results end up saved in the appropriate DM with text of all the info people are asking for. Pop just shows info GUVWAF posted. DM has all this plus any other info like timing as text.

Yep. They're a bit ephemeral at the minute, even if they succeed after you switch tabs they're lost.

GUVWAF commented 3 weeks ago

@cbvicious

Is there any possibility to add timestamps to each hop?

No, those are not sent over LoRa. It would also be hard to get valuable info from them, because each node uses random delays before transmitting and they might have other packets in their queue. Also nodes are not time-synchronized, at least not with second-level accuracy.

And/or how many attempts it took to make each hop?

Intermediate hops only ever try once. If the signal quality is strong and the traceroute fails, it's likely a packet collision.

andrekir commented 2 weeks ago

the traceroute dialog message takes a String type, so more complex layouts are not possible. someone could add colors using SpannableString but that's a lot of work. priority for now is to add the new 2.5 round-trip/SNR information in.