meshtastic / Meshtastic-Android

Android application for Meshtastic
https://meshtastic.org
GNU General Public License v3.0
737 stars 212 forks source link

[Feature Request]: Cached settings for admin commands #1272

Closed jeremiah-k closed 1 month ago

jeremiah-k commented 1 month ago

Contact Details

Jack! on Discord

Tell us your idea.

It would be really helpful if the app could cache a remote node’s admin settings so we don’t have to request them each time we want to make a change.

A lot of times it’s unnecessary to fetch the config from a remote node each time when we're the only one controlling it. If we’ve already accessed their settings, caching them would make things faster and would help reduce strain on the mesh.

For example, when I’m adjusting LongFast's location precision for a tree node, I have to re-request the channel settings before making each adjustment. Being able to use a cached versions of the settings would make this type of process a lot smoother.

Relevant log output

No response

Code of Conduct

andrekir commented 1 month ago

For example, when I’m adjusting LongFast's location precision for a tree node, I have to re-request the channel settings before making each adjustment.

you don't have to re-request the channels after each adjustment. after fetching the channels you can make multiple changes and send them one-by-one or all at once.

jeremiah-k commented 1 month ago

you don't have to re-request the channels after each adjustment. after fetching the channels you can make multiple changes and send them one-by-one or all at once.

That is true. In that instance, if using a second phone & device you can use that to check the changes on the map before backing out of the menu completely in the admin device's app.

If this isn't a direction that you're interested in going, that's okay. It was just something I ran into recently and thought it might be be worth considering anyway.

andrekir commented 1 month ago

I can totally relate! skipping the config fetch would be convenient but adds the risk of getting data out of sync. also 2.5 introduced a 5 minute window for changes after we fecth any config to prevent replay attacks, so there really isn't room for optimization.