🐞 [Bug]: ADC multiplier override missing from non-esp32 devices

meshtastic / Meshtastic-Apple

Apple iOS, iPadOS & macOS Clients For Meshtastic

https://meshtastic.org

GNU General Public License v3.0

225 stars 69 forks source link

🐞 [Bug]: ADC multiplier override missing from non-esp32 devices #698

Open rcarteraz opened 4 months ago

rcarteraz commented 4 months ago

Firmware Version

All

What did you do?

Try to set ADC multiplier override but unable to because it’s only available on esp32 devices.

Expected Behavior

To be able to set the ADC multiplier override on non-esp32 boards such as nRF52 and pico.

Current Behavior

Setting is not available

Participation

[] I am willing to submit a pull request for this issue.

Additional comments

No response

nolith commented 3 months ago

This is also missing for the heltec capsule sensor that is an esp32 device

tekstrand commented 2 months ago

Looked into this one a bit.

Issue seems to be here https://github.com/meshtastic/Meshtastic-Apple/blob/main/Meshtastic/Views/Settings/Config/PowerConfig.swift#L32

I think that either node, deviceConfig, or role is undefined which ends up preventing ADC config. I don't have the full emulator set up to be able to test this though.