search

meshtastic / Meshtastic-gui-installer

Cross platform, easy to use GUI for installing Meshtastic firmware.
https://meshtastic.org
GNU General Public License v3.0
68 stars 21 forks source link

[Bug]: Wifi password hardcoded as 'sekrit' #124

Closed SigmaScott closed 2 years ago

SigmaScott commented 2 years ago

Category

WiFi

Hardware

T-Beam

Firmware Version

v1.2.56.596a73c meshtastic flasher version 1.0.88

Description

When using the meshtastic flasher to config a device the password is set to 'sekrit' even after setting the password to correct password.

Relevant log output

No response

RicInNewMexico commented 2 years ago

Is it failing to connect to your wifi network? (stepping through the screens on your OLED display using the middle button should show a screen with wifi connection stats or alternatively you should see it listed as a client if you log into your wifi router and look through the DHCP leases).

None of the clients have the ability to retrieve a stored password from the device so they all display the password as 'sekrit' if a password is set. Is this what you are seeing or does it seem like it's actually setting it to 'sekrit' and causing it not to connect?

SigmaScott commented 2 years ago

yes it is failing to connect. I noticed this when going back in to turn on the mqqt it quit working. if I change it via the cli tools to the correct password it connects again.

SigmaScott commented 2 years ago

I have reset device to factory and been able to re create this. 1.factory reset, reset device

  1. start meshtastic flasher
  2. click on device setting
  3. on first page set short name and long name click save
  4. on wifi enter ssid and password click save
  5. on cli where flasher was started you can see loging that password and ssid like I set them
  6. restart device, it will connect
  7. go back into flasher and see the seekr it in the password field. update mqqt server, save
  8. device will no longer connect. from cli we can see it did change password to sekrit even though only mqqt setting was changed. re-setting password at same time as enable mqtt server does not have issue since password is updated in addition to mqtt server but it has correct password.
mc-hamster commented 2 years ago

@SigmaScott thanks for the report.

@RicInNewMexico sekrit is being set in: https://github.com/meshtastic/Meshtastic-device/blob/2a02b4594f5fa7067dfa5d6c55f5618f98974801/src/modules/AdminModule.cpp#L190

That's being called by: https://github.com/meshtastic/Meshtastic-device/blob/2a02b4594f5fa7067dfa5d6c55f5618f98974801/src/modules/AdminModule.cpp#L78

@mkinney I think this is a bug in either flasher or the python script. Some reason, it's calling into "AdminMessage_set_radio_tag" which is resetting the password.

bobatgit commented 2 years ago

Hi Folks!

I'm experiencing the same issue with two of my TTGO lora boards. Any time I set a wifi password it gets reset back to "sekrit" after saving it on the device. So, I'm unable to connect via WiFi at all.

Any advice on how I can fix this password issue? Thanks!

Device type: tlora-v1 Flasher version: v1.0.102 Firmware version: 1.2.59.d8c1c0.

Cheers, Bob