meshtastic / Meshtastic-gui-installer

Cross platform, easy to use GUI for installing Meshtastic firmware.
https://meshtastic.org
GNU General Public License v3.0
68 stars 21 forks source link

add estonian - et; discord user Le Andre to review #172

Closed mkinney closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #172 (ad59c77) into master (a8808b8) will decrease coverage by 0.59%. The diff coverage is 100.00%.

:exclamation: Current head ad59c77 differs from pull request most recent head b180ece. Consider uploading reports for the commit b180ece to get more accurate results

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   57.09%   56.50%   -0.60%     
==========================================
  Files          27       27              
  Lines        3433     3476      +43     
==========================================
+ Hits         1960     1964       +4     
- Misses       1473     1512      +39     
Flag Coverage Δ
unittests 56.50% <100.00%> (-0.60%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
meshtastic_flasher/form.py 80.38% <100.00%> (-0.97%) :arrow_down:
meshtastic_flasher/util.py 76.42% <0.00%> (-5.18%) :arrow_down:
meshtastic_flasher/plugins_telemetry_form.py 51.21% <0.00%> (-1.29%) :arrow_down:
meshtastic_flasher/radio_form.py 47.61% <0.00%> (-1.17%) :arrow_down:
meshtastic_flasher/plugins_rotary_encoder_form.py 43.97% <0.00%> (-0.96%) :arrow_down:
meshtastic_flasher/wifi_and_mqtt_form.py 51.66% <0.00%> (-0.92%) :arrow_down:
meshtastic_flasher/power_form.py 47.16% <0.00%> (-0.91%) :arrow_down:
meshtastic_flasher/fixed_position_form.py 57.83% <0.00%> (-0.07%) :arrow_down:
meshtastic_flasher/plugins_range_test_form.py 57.31% <0.00%> (-0.02%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9139228...b180ece. Read the comment docs.

fsgl1tch commented 2 years ago

The review is still in progress, the text fields need many changes. Doing in the evening bit by bit 😄

fsgl1tch commented 2 years ago

@mkinney I have completed the task, it is no means perfect, but at least it conveys the point in Estonian in semi good fashion. I will probably update these translations once I get to play with the module and understand the descriptions a little better. How should I proceed now? I have made the changes in the .json file

mkinney commented 2 years ago

Where are the changes? You can drag and drop the file on a comment, if that is easy for you.

fsgl1tch commented 2 years ago

I do not have commit right, so I cannot just push the changes to the branch. I pulled changes from upstream and created my own add_estonian branch. GitHub does not ;et me copy the json file here so ... any other proposals?

mkinney commented 2 years ago

You can create a new PR if you want. Or, you can share the file in a comment on GitHub or in Discord. Whatever is easiest.