search

meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
3k stars 719 forks source link

loss of GPS lock not updated in the GUI #284

Closed geeksville closed 3 years ago

geeksville commented 3 years ago

but the problem isn't the GUI. It is that we only publish GPS updates when we have lock. Once we lose lock we stop publishing. Really - we should do one last publish when the state changes from locked to not locked (so the rest of the app establishes the new proper !locked state).

This fix should go into 1.0 (master).

From this forum report:

geeksville commented 3 years ago

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/bug-tbeam-never-returns-to-no-sats-state/741/2

Professr commented 3 years ago

Mind if I fix this one?

geeksville commented 3 years ago

Feel free to fix any one you want! ;-)

On Tue, Jul 14, 2020 at 9:57 PM Ellie Hussey notifications@github.com wrote:

Mind if I fix this one?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/meshtastic/Meshtastic-device/issues/284#issuecomment-658545703, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXB2KJHB7HLQSUSLRQ3VLR3UZMXANCNFSM4O2E62MA .

Professr commented 3 years ago

Hmm. NEMA already looks ok, but UBlox always reports its last known fix. Fortunately it seems to update the number of satellite locks it has, so I integrated that into the logic that determines whether the module has a lock or not. It takes 5-10 minutes to really pick up on the loss of lock, but it does go back to "No sats" at that point.