search

meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
3.22k stars 778 forks source link

GPS power enable pin not defined in latest versions for Heltec v3 #2877

Closed Juzzle1 closed 10 months ago

Juzzle1 commented 10 months ago

Category

Hardware Compatibility

Hardware

Heltec V3

Firmware Version

2.2.10 / Master

Description

For Heltec v3, the PIN_GPS_EN define has been removed from variant.h in https://github.com/meshtastic/firmware/pull/2799

Without this, now my GPS modules remain powered even when I shutdown the device (I can see the LEDs are still active on on the module), causing the battery to drain.

I also noticed that this pin definition has not been removed for the Heltec WSL in this same PR.

For reference my GPS modules are switched via a 2N2222 transistor with base connected to pin 46.

Relevant log output

No response

jp-bennett commented 10 months ago

It's been moved to a config option. I'm not sure if any of the clients support it yet, but it's position.gps_en_gpio. I'll take a look at getting it into the Python client.

Juzzle1 commented 10 months ago

Great, thanks!

jp-bennett commented 10 months ago

Looks like it's already present in the latest Python client. So meshtastic --set position.gps_en_gpio 46 should get you back.

Juzzle1 commented 10 months ago

Ah, probably need to update my client to see it.

Thanks for looking!