automatically propose to setup virtualenv if platformio is having issues in native build

meshtastic / firmware

Meshtastic device firmware

https://meshtastic.org

GNU General Public License v3.0

2.89k stars 670 forks source link

automatically propose to setup virtualenv if platformio is having issues in native build #3905

Closed Jorropo closed 2 weeks ago

Jorropo commented 2 weeks ago

I'm not sure it's quite the right thing to do, it tooks me a dozen minutes to find which version of platformio would work when trying to build on ubuntu jammy.

Jorropo commented 2 weeks ago

bin/build-native.py:3:0
 3:0  low  Consider possible security implications associated with the subprocess module.  bandit/B404
10:0  low  subprocess call - check for execution of untrusted input.                       bandit/B603

Yes, I know, that the point, is there a way to to acknowledge theses so CI is happy ?

caveman99 commented 2 weeks ago

Same problem is on your other not-so-trivial PR. Newer trunk is really picky about these things. I'll have a look how to either tell it to not treat these as warnings or ignore 'low' category alltogether.

Jorropo commented 2 weeks ago

I got a better idea