search

meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
3k stars 715 forks source link

Added "Hops away" on display #3934

Closed capslockapocalypse closed 1 month ago

capslockapocalypse commented 1 month ago

Added in logic that displays "hops away" instead of signal strength on the display when the node is more than 0 hops away. Any feedback to tidy up is appreciated.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

capslockapocalypse commented 1 month ago

Apologies If I'm not doing this right, first time using github and contributing. I'm assuming I need to get the Trunk Check Runner to pass? and that it's hanging on the extensions file.

thebentern commented 1 month ago

Apologies If I'm not doing this right, first time using github and contributing. I'm assuming I need to get the Trunk Check Runner to pass? and that it's hanging on the extensions file.

Everything looks good on that front. You just need to revert your commit to the .vscode/extensions.json file. :-)

capslockapocalypse commented 1 month ago

Thank you for your help and patience, if this doesn't work I'll just retry the whole pull request.

HarukiToreda commented 1 month ago

Added in logic that displays "hops away" instead of signal strength on the display when the node is more than 0 hops away. Any feedback to tidy up is appreciated.

do you have some screenshots to show it looks?