meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
2.99k stars 715 forks source link

[Bug]: Triple-click behaviour for GPS doesn't work as expected #3976

Closed Nestpebble closed 3 weeks ago

Nestpebble commented 1 month ago

Category

Other

Hardware

DIY

Firmware Version

2.3.10

Description

Following on from testing for issue 3742, it appears that triple-click to disable the GPS doesn't always behave correctly. I'm using a Pro-micro DIY board with a transistor to switch the GPS ground as required, but the results have been replicated on other hardware. The issue is: when triple-click is used to disable the GPS whilst the GPS is in sleep mode, the pin_gps_en pin doesn't go low (i.e. off), and the GPS isn't told to sleep permanently. After the sleep period has elapsed (i.e. 120 seconds), the GPS wakes up and tries to communicate with the MCU, but is ignored. It consumes full power doing this, and does so for an indefinite period of time, effectively negating any power savings from the sleep mode. When the GPS is triple-click disabled while it is in search mode, it is powered off via the gps_en pin correctly, and the sleep command is issued correctly. Some work has been done to find the issue, discussed on the discord in #"GPS EN Pin discussion" and summarised in these messages.

Relevant log output

No response

todd-herbert commented 1 month ago

Just to add: this branch might fix the issue. I gave it a quick check with the device I had on-hand, and it seemed to work, but needs some more testing to confirm.

todd-herbert commented 3 weeks ago

Hopefully solved by #4041

Nestpebble commented 3 weeks ago

Solved by #4041.

Edit: many thanks, @todd-herbert!