search

meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
2.98k stars 714 forks source link

Don't send potentially bogus timestamps with fixed location #4001

Closed jp-bennett closed 1 month ago

jp-bennett commented 1 month ago

I'm seeing a situation where a "rogue" node thinks it has a valid timestamp, but doesn't. It's using fixed position, so the wrong timestamp is overwriting a time provided by another node that actually has a GPS.

wnagele commented 3 weeks ago

@thebentern this will result in no time source availability in a mesh where no GPS nodes are present. I would suggest to still allow NTP otherwise this is a pretty drastic change.

thebentern commented 3 weeks ago

Yes, I think NTP quality is probably a good compromise of allowing time source injections while avoiding poor quality times. Care to make a PR?

@thebentern this will result in no time source availability in a mesh where no GPS nodes are present. I would suggest to still allow NTP otherwise this is a pretty drastic change.

wnagele commented 3 weeks ago

Here you go: https://github.com/meshtastic/firmware/pull/4068