GPS Power State tidy-up

todd-herbert commented 4 months ago

In https://github.com/meshtastic/firmware/pull/4070 I said I'd follow up and have a go at tidying the GPS class, with the intention of then hunting down a bug affecting U-blox standby. I'm not at all confident working with GPS hardware, so this submission is a rough first draft. Seeking feedback / contribution / testing!

Initial intentions:

Encapsulate code which schedules GPS updates
Tighter interaction with the GPSPowerState enum
Remove an unused GPS Sleep Observable
Control sleep with high-level up(), down() methods

Update: See https://github.com/meshtastic/firmware/pull/4161#issuecomment-2202079700 for latest summary

todd-herbert commented 4 months ago

@thebentern Just so you're in the loop, are you comfortable with the idea of merging this?

GPSFan commented 4 months ago

just building the code now.

meshtastic-bot commented 3 months ago

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/lilygo-t-echo-fw-2-2-11-10265aa-issue/8331/11

meshtastic / firmware

GPS Power State tidy-up #4161