search

meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
3.65k stars 918 forks source link

[Bug]: When we format nrf52 filesystem, we must then rewrite the adafruit BLE paring file #4448

Closed geeksville closed 3 months ago

geeksville commented 3 months ago

Category

Hardware Compatibility

Hardware

Not Applicable

Firmware Version

master (private build)

Description

While fixing #4395. I noticed a problem which has been existing ever since we started reformatting nrf52 filesystems:

Our current solution will format the FS if a corrupted filesystem is detected. This is the best we can do with the current LFS and 4K nrf52 page sizes. If we do need to do this repair, in many cases we are now able to preserve our full node config, except for BLE pairing info.

We need to look into the adafruit/bluefruit code to figure out how to force the BLE layer to rewrite its pairing data. We should call that code from NodeDB::saveToDisk() any time we decide we must reformat the FS.

Relevant log output

No response

geeksville commented 3 months ago

working on this one now.

geeksville commented 3 months ago

hmm - actually as part of investigating this I looked through bonding.cpp and BLEConnection.cpp in the adafruit code. I think we don't need to worry about this. As long as the device is acting as a BLE server only the adafruit code isn't saving anything to the /adafruit directory. So I'm going to send in a small PR that just improves the file list code (so we can see that those dirs are empty during normal operation.