search

meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
3.58k stars 891 forks source link

Potential fix for bad Rx performance on T1000-E #4885

Closed GUVWAF closed 1 month ago

GUVWAF commented 1 month ago

This seems to fix the part of the issue from #4775 where it only hears SX126x/LR11x0 radios that are close. While the RadioLib example mentions setRfSwitchTable() should be called before begin(), we called setDioAsRfSwitch() (which gets called inside setRfSwitchTable()) at this place before https://github.com/meshtastic/firmware/commit/2f0c19ebeac0054cb8b8f417b9f2952d18532fce.

caveman99 commented 1 month ago

Let's try it. setDioAsRfSwitch is godmode only btw... :-) I just went by the documentation.

GUVWAF commented 1 month ago

@caveman99 Can you try if this doesn't break on another LR11x0 dev board you have?

caveman99 commented 1 month ago

@caveman99 Can you try if this doesn't break on another LR11x0 dev board you have?

I will tomorrow morning. Also i wanna put the Switch matrix into variant.h or next to it for each board and just leave the default in the firmware code. Not have a giant ifdef construct there.

caveman99 commented 1 month ago

@caveman99 Can you try if this doesn't break on another LR11x0 dev board you have?

seems to work fine with all boards, can you review my changes?

GUVWAF commented 1 month ago

Looks good and clean!