search

meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
3.35k stars 816 forks source link

Ignore seen phoneapi packets #4888

Open thebentern opened 4 hours ago

thebentern commented 4 hours ago

Turns out some of the Phone API spam is actually replaying the same packets. This completely silences the Rate limit notification spam on my devices.

GUVWAF commented 3 hours ago

Do we know why it is replaying the same packets?

I'm not sure if all clients actually set a packet ID or leave it 0, which would not work with this.

thebentern commented 3 hours ago

Do we know why it is replaying the same packets?

No, I have been trying to figure out if it's somehow related to the push / pull system of notify and read value from characteristic or something going haywire in the bluetooth stack in iOS. I have not reproduced it on the Android side, but I have not done much testing there.

I'm not sure if all clients actually set a packet ID or leave it 0, which would not work with this.

I know iOS is generating packet IDs, but I'll double check if Android as well.

jp-bennett commented 2 hours ago

Or just make an exception for packets with num of 0

thebentern commented 2 hours ago

Or just make an exception for packets with num of 0

Easy addition. I'll whip this up