low data rate optimization should be turned on for sx1276 radios

meshtastic / firmware

Meshtastic device firmware

https://meshtastic.org

GNU General Public License v3.0

3.44k stars 843 forks source link

low data rate optimization should be turned on for sx1276 radios #517

Closed geeksville closed 3 years ago

geeksville commented 3 years ago

the sx1262 does this correctly but radiolib has a bug on sx1276. Need to set SX127X_REG_MODEM_CONFIG_3 LowDataRateOptimize when symbol length exceeds 16ms.

geeksville commented 3 years ago

Never mind - I went to fix this just now and discovered it was properly implemented in SX1278.cpp (though not in the sx127x.cpp baseclass. So it already works fine as we've been using it.