meshtastic / firmware

Meshtastic device firmware
https://meshtastic.org
GNU General Public License v3.0
3.3k stars 799 forks source link

LLCC68 LoRa module processing without SF12 support #926

Closed osmanovv closed 2 years ago

osmanovv commented 2 years ago

Recently I have added support for the LLCC68 module in DIY devices (#918).

This module can work with the current firmware to a limited extent since it does not support Spreading Factor 12 (13.4.5.2 LoRa® Modulation Parameters, LLCC68 Data Sheet), therefore will not work on the default "Long Slow" channel. The firmware throws Critical Error #3 and would be nice to see a hint about channel switching or the limitations of this module.

It should be remembered that this LLCC68 module is implemented over SX1262 and could be functioning on firmware for SX1262/SX1268 modules.

Discussion link: https://meshtastic.discourse.group/t/meshtastic-diy-project/3831/20

geeksville commented 2 years ago

This issue has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-diy-project/3831/24

sachaw commented 2 years ago

As hints are something that are implemented in clients this is out-of-scope for the firmware, however there is an approaches that would prevent the error: Perform a check when the sf is set to 12 and for the presence of a LLCC68 if so, don't do anything, then clients could set any value they want and the troublesome one just gets ignored.