Update GitHub Actions - Githubissues

meshtastic / js

JS/TS library for interfacing with Meshtastic devices

https://meshtastic.org

GNU General Public License v3.0

75 stars 36 forks source link

Update GitHub Actions #105

Open Hunter275 opened 2 weeks ago

Hunter275 commented 2 weeks ago

Update GitHub actions now that the repo is getting more attention.

This will change a lot as I learn more about GitHub Actions. If you'd like to lend a hand please comment.

TODO:

[x] Update version to match protobuf versions
[ ] Create an Action to update protobufs automatically and release a new version
- [ ] BONUS: Update protobuf's Actions to fire off this Action or subscribe to protobuf releases somehow
[ ] Don't allow updates to .github files to update Actions and run without approval (SECURITY)
[ ] Ensure the version is bumped when merging to master
[ ] Only publish to NPM and JSR when a release is created

Hunter275 commented 2 weeks ago

Tool for testing workflows, going to see if I can get it working

https://github.com/nektos/act

Hunter275 commented 2 weeks ago

Update version to match protobufs version https://github.com/meshtastic/protobufs/

Hunter275 commented 2 weeks ago

Notes from @thebentern

Workflow_dispatch adds a button to "Run Workflow" and allows you to select a branch from Actions to run the workflow on.

Then use if: ${{ github.event_name == 'workflow_dispatch' }} to gate jobs

Hunter275 commented 2 weeks ago

The "version check" job needs to run when a PR is created with the target branch of master, it currently does not.

Hunter275 commented 2 weeks ago

I'm not sure if this just isn't an issue because I'm a meshtastic org member but I am able to modify the Actions and they run on the PR with the updated .yml files, thats a huge red flag to me and we need to protect ourselves on our other repos.