search

meshtastic / js

JS/TS library for interfacing with Meshtastic devices
https://meshtastic.org
GNU General Public License v3.0
75 stars 36 forks source link

Update meshtastic-js to newer protobuf spec #97

Closed johnlaur closed 3 weeks ago

johnlaur commented 3 weeks ago

Closes: https://github.com/meshtastic/js/issues/96

This PR bumps package versions; most importantly @buf/meshtastic_protobufs.bufbuild_es

The factory reset API has since been refactored into separate reset device and reset config instructions. I updated the function names to match which removes the previously available factoryReset() API. If there is a desire to maintain backwards compatibility, factoryReset() could be aliased to factoryResetDevice().

I have also not incremented the meshtastic-js version number as defined in package.json.

CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 3 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Hunter275 commented 3 weeks ago

@johnlaur

Build error: ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json

Please include the pnpm-lock.yaml file in your PR

johnlaur commented 3 weeks ago

Sorry I am new to pnpm. I will figure that out and post a fix.

Hunter275 commented 3 weeks ago

Sorry I am new to pnpm. I will figure that out and post a fix.

No problem. You shouldn't need to do anything except commit that file to the branch.

johnlaur commented 3 weeks ago

Hey thank you for the merge and sorry for the delay; I was just able to get back to look at this today. I do have pnpm set up now.