search

meshtastic / node-red-contrib-meshtastic

GNU General Public License v3.0
12 stars 5 forks source link

Decode node overlapping with Protobuf's decode node and nodes reacting weirdly in Node Red #4

Open ToSMaverick opened 1 year ago

ToSMaverick commented 1 year ago

First of all thank you for creating a Node-RED package! I was using node-red-contrib-protobuf so far to decode Meshtastic's MQTT packets in NR. Your implementation could simplify this process quite a bit. image

During my attempts to install the package I noticed the following:

  1. Node-RED has to be 3.0.2 or higher. I had 2.2.2 so an upgrade was due
  2. Since I had the protobuf package installed, NR notified me that the "decode" node was already registered. I had to uninstall it in order to get the decode node working.
  3. When I dragged the nodes in, NR was acting very weird. The node was still shown even when I switched flows. Sometimes it reset the view and the node was suddenly on the top left of the flow. Properties were empty (not sure if there are even things to be set).

In order to solve these issue I'd suggest to

  1. Add a hint regarding the version to the readme file
  2. Add a prefix to the node. TP-Link for example does this with their smart plugs. image

And lastly, any suggestions for this strange node behavior in NR?

sachaw commented 9 months ago

@scruplelesswizard Thoughts?

scruplelesswizard commented 9 months ago

I've seen similar behaviour, I think it has to do with the node initilization. I did some initial work on shoring that up but I'll take a look further in to this once we have #15 resolved