search

meshtastic / protobufs

Protobuf definitions for the Meshtastic project
https://meshtastic.org
GNU General Public License v3.0
77 stars 115 forks source link

Generalize E22-900M_S3 to EBYTE_ESP32-S3 #394

Closed S5NC closed 10 months ago

S5NC commented 10 months ago

For https://github.com/meshtastic/firmware/pull/2882 to encompass more EBYTE modules without requiring adding future variants

S5NC commented 10 months ago

Is using _s in the place of -s in this file a convention or strictly necessary?

S5NC commented 10 months ago

https://github.com/meshtastic/firmware/blob/9d1fe8c245b71247a6e8f2868a1642bdfe60aaa2/src/mesh/generated/meshtastic/mesh.pb.h#L22C6-L22C6 surely this doesn't apply if the board did not exist before Meshtastic v2? Using a - would prevent having awkward mismatch between directory and hardware name, as seen in platformio.ini

  -D EBYTE_ESP32_S3
  -I variants/EBYTE_ESP32-S3