Open haxney opened 10 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
With multiple different triggers and actions, the number of fields in the
ExternalNotificationConfig
was starting to grow large, and the interactions between the different fields was complicated.Example
For example, if someone wanted the configuration
then the
ExternalNotificationConfig
message would need a field:And so on for each combination of conditions and actions.
This commit
This commit introduces the
ExternalNotificationCase
message, which separates the condition (when to trigger an external notification) from the action (which pin to activate). The previous example would look like this:Adding new conditions (such as a message text containing a string prefix or being sent by a particular node) and actions (such as a fourth output pin) does not result in a combinatorial explosion of fields and keeps the implementation simpler.