search

meshtastic / protobufs

Protobuf definitions for the Meshtastic project
https://meshtastic.org
GNU General Public License v3.0
77 stars 115 forks source link

Changed the variable length of wifi_psk #402

Closed tobi-sys closed 9 months ago

tobi-sys commented 9 months ago

Correct the length of the variable wifi_psk

WiFi PSK can be 256 bits = 32 Bytes and can be represented by a 64 character long hexadecimal string The size of the variable must be 65 bytes to hold the string and the trailing \0

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

garthvh commented 9 months ago

This change would need to be made in the protobufs repo

garthvh commented 9 months ago

Sorry, missed the repo, was looking at another issue. Is 1 byte more enough to save a 64 byte password? We probably can’t go much bigger.

tobi-sys commented 9 months ago

currently 63 character long key can be stored in the variable _meshtastic --set network.wifi_psk 123456789A123456789B123456789C123456789D123456789E123456789F123 Connected to radio Set network.wifi_psk to 123456789A123456789B123456789C123456789D123456789E123456789F123 Writing modified preferences to device meshtastic --get network.wifi_psk Connected to radio network.wifipsk: 123456789A123456789B123456789C123456789D123456789E123456789F123 Completed getting preferences a one byte longer variable (so 65 bytes) can hold the possible 64 character long PSK and the string termination (\0)

tobi-sys commented 9 months ago

relates to the pull request https://github.com/meshtastic/meshtastic/pull/875

thebentern commented 9 months ago

Please sign the CLA