search

meshtastic / protobufs

Protobuf definitions for the Meshtastic project
https://meshtastic.org
GNU General Public License v3.0
77 stars 115 forks source link

Revert "Add role to NodeInfo/Lite" #406

Closed thebentern closed 9 months ago

thebentern commented 9 months ago

Reverts meshtastic/protobufs#405

As smoke pointed out, this actually needs to go onto User which is what NodeInfoModule allocates in the meshpacket payload. Meh!

ajmcquilkin commented 9 months ago

Why does this need to go in user? This doesn't feel like something that's specific to the user of the radio

thebentern commented 9 months ago

Why does this need to go in user? This doesn't feel like something that's specific to the user of the radio

User is what the NodeInfoModule actually allocates for the payload. It's part of the issue with the current architecture that we want to break out for 3.0. User will be completely decoupled from NodeInfo then.

https://github.com/meshtastic/firmware/blob/c7e3485dd77eff6632c7c9e053d73b9269c42422/src/modules/NodeInfoModule.cpp#L68