search

meshtastic / protobufs

Protobuf definitions for the Meshtastic project
https://meshtastic.org
GNU General Public License v3.0
83 stars 118 forks source link

StoreForward: replace "empty" by "text" and improve comments #437

Closed GUVWAF closed 7 months ago

GUVWAF commented 7 months ago

This will replace the currently unused "empty" variant of the StoreForward message to "text", such that clients know how to handle the history from the server. Technically a breaking change, but the "empty" variant was not used in the firmware.

Also updated some of the comments of other fields.

andrekir commented 7 months ago

@GUVWAF what do you think of having both a text_broadcast and text_direct oneOf added?

this way we can separate broadcasts from direct messages like the Delayed field was designed (below): text_broadcast we replace the to with the broadcast node number; text_direct is a DM for us.

we would then need to pick the oneOf based on packetHistoryTXQueue[packetHistory_index].to here

https://github.com/meshtastic/protobufs/blob/1fa72525a13117908a850d6754b5368eabdee163/meshtastic/mesh.proto#L861-L876

GUVWAF commented 7 months ago

Good idea. Or should we add two RequestResponse tags instead? One for text_direct and one for text_broadcast? Currently I'm using the UNSET.

andrekir commented 7 months ago

Good idea. Or should we add two RequestResponse tags instead? One for text_direct and one for text_broadcast? Currently I'm using the UNSET.

commented on https://github.com/meshtastic/firmware/pull/3194#issuecomment-1937766213