Add E-Ink options to DisplayConfig

meshtastic / protobufs

Protobuf definitions for the Meshtastic project

https://meshtastic.org

GNU General Public License v3.0

73 stars 107 forks source link

Add E-Ink options to DisplayConfig #474

Closed todd-herbert closed 3 months ago

todd-herbert commented 3 months ago

Intention is to expose two new settings to users:

E-Ink Screensaver: what behavior to use when display updates are paused
E-Ink Full Sun: slower, more robust. Hopes to improve outdoor performance for some displays

Neither of these features are implemented just yet. Screensaver code is a work-in-progress: https://github.com/meshtastic/firmware/pull/3477

Changes tested locally with the python CLI; unsure what work is necessary to eventually expose the new settings in the mobile apps / Web UI.

todd-herbert commented 3 months ago

I hear you. This was a reaction to feedback on the initial screensaver pull request, essentially a difference of opinion on aesthetics. The hope here was that no users gets stuck with a feature they are unhappy about. Definitely a bit of feature creep though, and yeah possibly a step too far.

Personally, after implementing the different options yesterday, I have come around and probably now prefer the subtle overlay option suggested on the firmware pull-request.

todd-herbert commented 3 months ago

I will still look into the full-sun config option in the near future.