search

meshtastic / protobufs

Protobuf definitions for the Meshtastic project
https://meshtastic.org
GNU General Public License v3.0
83 stars 118 forks source link

Added mute channel into module settings #492

Closed thebentern closed 5 months ago

thebentern commented 5 months ago

This will allow the configuration of a "muted" channel to stay with the device, but be enforced on client / apps Closes #490

ianmcorvidae commented 5 months ago

I thought that ModuleSettings was mostly intended for stuff related to modules (Position for position_precision, MQTT uplink/downlink predate it but otherwise would belong), and unsure this really corresponds to one. I'm not sure if that makes much difference either though -- ModuleSettings isn't a great name for "stuff we want to configure but not put in QR codes" but maybe that's what it effectively is

ianmcorvidae commented 5 months ago

I guess most things are labeled as modules eventually in the firmware code, so I'm probably splitting hairs uselessly :laughing:

seems good to me probably, anyway

thebentern commented 5 months ago

ModuleSettings isn't a great name for "stuff we want to configure but not put in QR codes" but maybe that's what it effectively is

I agree with this. We should probably rename it to something like ExtendedSettings perhaps?

garthvh commented 5 months ago

ModuleSettings isn't a great name for "stuff we want to configure but not put in QR codes" but maybe that's what it effectively is

This is what it really is, weird naming did not stand out when @jp-bennett and I did it, but it seems off now for sure.

tekstrand commented 5 months ago

🥳 nice work