search

meshtastic / protobufs

Protobuf definitions for the Meshtastic project
https://meshtastic.org
GNU General Public License v3.0
71 stars 106 forks source link

Add FileInfo packet to FromRadio #525

Closed thebentern closed 1 week ago

thebentern commented 1 week ago

These will be sent up on want_config flow to inform clients of the device's file system manifest file-by-file.

ianmcorvidae commented 1 week ago

It seems to me that an admin message would be more useful along with delete_file_request admin messages (and that would mean this information isn't pushed at you every time you connect to anything), but I'm not sure if you elected against that due to the data volume it'd put on the mesh? I think that if the only reason it's here and not admin is that nobody but me is intending to implement delete_file_request then I'd suggest we move it, but I'm also not that bothered by this being on the client connection only, given even if it might sometimes be useful on remote nodes that's advanced usage.

thebentern commented 1 week ago

It seems to me that an admin message would be more useful along with delete_file_request admin messages (and that would mean this information isn't pushed at you every time you connect to anything), but I'm not sure if you elected against that due to the data volume it'd put on the mesh? I think that if the only reason it's here and not admin is that nobody but me is intending to implement delete_file_request then I'd suggest we move it, but I'm also not that bothered by this being on the client connection only, given even if it might sometimes be useful on remote nodes that's advanced usage.

I'm considering doing some follow-up work on an admin message side implementation. It's just not as clear cut because we'll have to reply with multiple messages or make a repeated with potentially chunked messages, since I could see an esp32 with the web hosted interface files, a rangetest, and all of the prefs could likely blow out the MTU pretty easily. The phone API is pretty easy to hook into in this regard because we can get away with pumping out the individual file infos like we do with nodeinfo for instance and not suffer the horrendous overhead of doing it this way over LoRA.

ianmcorvidae commented 1 week ago

Ah, yeah, that definitely makes sense. And I didn't think of the fact it can get added as an admin message later anyway, so that gets rid of my concerns for sure!