search

meshtastic / python

The Python CLI and API for talking to Meshtastic devices
https://meshtastic.org
407 stars 170 forks source link

Change modem preset shortcuts to not request channels, and to request remote config when needed #668

Closed ianmcorvidae closed 2 months ago

ianmcorvidae commented 2 months ago

Fixes #662

This should change the --ch-<preset> commands to behave equivalently to --set lora.modem_preset <preset>

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.44%. Comparing base (aa6f096) to head (8ba92da). Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #668 +/- ## ========================================== - Coverage 61.48% 61.44% -0.04% ========================================== Files 24 24 Lines 3593 3595 +2 ========================================== Hits 2209 2209 - Misses 1384 1386 +2 ``` | [Flag](https://app.codecov.io/gh/meshtastic/python/pull/668/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meshtastic/python/pull/668/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic) | `61.44% <0.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meshtastic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.