Closed djholt closed 1 month ago
Attention: Patch coverage is 33.33333%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 60.91%. Comparing base (
48a06c6
) to head (40353a3
). Report is 3 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
meshtastic/node.py | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good! Thanks for picking this up, I hadn't gotten to it yet. I don't think we need to worry about older firmware versions. They'll reject any updates that get sent by this, but if someone hasn't updated they're probably aware of that constraint anyway.
Based on recent firmware change to allow remote admin position config.
Question: do we need to handle old firmware versions with this change?