vercel[bot]
commented
5 months ago @rcarteraz is attempting to deploy a commit to the Meshtastic Team on Vercel.
A member of the Team first needs to authorize it.
Closed rcarteraz closed 5 months ago
vercel[bot]
commented
5 months ago @rcarteraz is attempting to deploy a commit to the Meshtastic Team on Vercel.
A member of the Team first needs to authorize it.
vercel[bot]
commented
5 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| web-flasher | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 5, 2024 7:40pm |
pdxlocations
commented
5 months ago The web serial compatibility link jumps to https://meshtastic.org/docs/software/web-client#serial-usb Perhaps it would be better to link to: https://meshtastic.org/docs/software/web-client#compatibility
Not sure the link is really needed, could just say Chrome and Edge?
rcarteraz
commented
5 months ago The web serial compatibility link jumps to https://meshtastic.org/docs/software/web-client#serial-usb Perhaps it would be better to link to: https://meshtastic.org/docs/software/web-client#compatibility
Not sure the link is really needed, could just say Chrome and Edge?
That was intentional, just "Chrome or Edge" is too vague because mobile chrome and edge would not be supported. The link directs them straight a chart that automatically updates with supported browsers so if new browsers are added we wouldn't have to update to say "Chrome or Edge or Safari" for example.
pdxlocations
commented
5 months ago The web serial compatibility link jumps to https://meshtastic.org/docs/software/web-client#serial-usb Perhaps it would be better to link to: https://meshtastic.org/docs/software/web-client#compatibility
Not sure the link is really needed, could just say Chrome and Edge?
That was intentional, just "Chrome or Edge" is too vague because mobile chrome and edge would not be supported. The link directs them straight a chart that automatically updates with supported browsers so if new browsers are added we wouldn't have to update to say "Chrome or Edge or Safari" for example.
This is where that link leads me
pdxlocations
commented
5 months ago Oh now I get it. Sorry! I should probably look at the chart, I just read the paragraph which seems out of context because it isn't a list of browsers. @rcarteraz
I approve of the link as-is.
rcarteraz
commented
5 months ago The web serial compatibility link jumps to https://meshtastic.org/docs/software/web-client#serial-usb Perhaps it would be better to link to: https://meshtastic.org/docs/software/web-client#compatibility Not sure the link is really needed, could just say Chrome and Edge?
That was intentional, just "Chrome or Edge" is too vague because mobile chrome and edge would not be supported. The link directs them straight a chart that automatically updates with supported browsers so if new browsers are added we wouldn't have to update to say "Chrome or Edge or Safari" for example.
This is where that link leads me
That's where it should lead. I have to link it to the header, can't link it directly to the image.
rcarteraz
commented
5 months ago Oh now I get it. Sorry! I should probably look at the chart, I just read the paragraph which seems out of context because it isn't a list of browsers. @rcarteraz
I approve of the link as-is.
I mean I could link it directly to the image but it will go directly to the image rather than the docs. I just figured this was better but I'm okay with changing it.
pdxlocations
commented
5 months ago Oh now I get it. Sorry! I should probably look at the chart, I just read the paragraph which seems out of context because it isn't a list of browsers. @rcarteraz I approve of the link as-is.
I mean I could link it directly to the image but it will go directly to the image rather than the docs. I just figured this was better but I'm okay with changing it.
Honestly, I find the chart extremely confusing, and the page is specifically referring to the web client. I'd rather just be told what browser to use.
rcarteraz
commented
5 months ago Oh now I get it. Sorry! I should probably look at the chart, I just read the paragraph which seems out of context because it isn't a list of browsers. @rcarteraz I approve of the link as-is.
I mean I could link it directly to the image but it will go directly to the image rather than the docs. I just figured this was better but I'm okay with changing it.
Honestly, I find the chart extremely confusing, and the page is specifically referring to the web client. I'd rather just be told what browser to use.
Fine.
This PR adds WebSerial detection and presents a very visible warning if not detected. This is so that a user is aware their browser is not compatible with the WebSerial flashing tech being used with the Meshtastic flasher.