search

meshuggahtas / tasvideos

Archived issues for TASVideos repo
GNU General Public License v3.0
1 stars 3 forks source link

Shell - Results of shellcheck linter (version 0.8.0) #3

Open meshuggahtas opened 2 years ago

meshuggahtas commented 2 years ago 
1. In /github/workspace/serverscripts/dns_add_godaddy.sh line 3:
source ~tasvideos/.secrets/GODADDY_VARIABLES
       ^-- SC1091 (info): Not following: ~tasvideos/.secrets/GODADDY_VARIABLES: openBinaryFile: does not exist (No such file or directory)

2. In /github/workspace/serverscripts/dns_add_godaddy.sh line 5:
echo $1 - $2
     ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
          ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
echo "$1" - "$2"

3. In /github/workspace/serverscripts/dns_add_godaddy.sh line 12:
headers="Authorization: sso-key $key:$secret"
                                ^--^ SC2154 (warning): key is referenced but not assigned.
                                     ^-----^ SC2154 (warning): secret is referenced but not assigned.

4. In /github/workspace/serverscripts/dns_del_godaddy.sh line 3:
source ~tasvideos/.secrets/GODADDY_VARIABLES
       ^-- SC1091 (info): Not following: ~tasvideos/.secrets/GODADDY_VARIABLES: openBinaryFile: does not exist (No such file or directory)

5. In /github/workspace/serverscripts/dns_del_godaddy.sh line 8:
ttl="3600"                                  # Time to Live min value 600
^-^ SC2034 (warning): ttl appears unused. Verify use (or export if used externally).

6. In /github/workspace/serverscripts/dns_del_godaddy.sh line 10:
headers="Authorization: sso-key $key:$secret"
                                ^--^ SC2154 (warning): key is referenced but not assigned.
                                     ^-----^ SC2154 (warning): secret is referenced but not assigned.

7. In /github/workspace/serverscripts/pull.sh line 2:
source ~/homedir
       ^-------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.

8. In /github/workspace/serverscripts/pull.sh line 4:
cd $HOME_DIR/tasvideos
^--------------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
   ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
cd "$HOME_DIR"/tasvideos || exit

9. In /github/workspace/serverscripts/tasvideos-service.sh line 18:
DOTNET_RUNTIME=/usr/bin/dotnet
^------------^ SC2034 (warning): DOTNET_RUNTIME appears unused. Verify use (or export if used externally).

10. In /github/workspace/serverscripts/tasvideos-service.sh line 39:
  if [ -f $PIDFILE ] && kill -0 $(cat $PIDFILE); then
                                ^-------------^ SC2046 (warning): Quote this to prevent word splitting.

11. In /github/workspace/serverscripts/tasvideos-service.sh line 45:
    ENV=`cat $ENVIRONMENT_FILE`
        ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean: 
    ENV=$(cat $ENVIRONMENT_FILE)

12. In /github/workspace/serverscripts/tasvideos-service.sh line 61:
  if [ ! -f "$PIDFILE" ] || ! kill -0 $(cat "$PIDFILE"); then
                                      ^---------------^ SC2046 (warning): Quote this to prevent word splitting.

13. In /github/workspace/serverscripts/tasvideos-service.sh line 68:
  su -c "start-stop-daemon -K -p \"$PIDFILE\"" $WWW_USER
                                               ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  su -c "start-stop-daemon -K -p \"$PIDFILE\"" "$WWW_USER"

14. In /github/workspace/serverscripts/tasvideos-service.sh line 126:
  echo 'Error code' $EC 'received during' $1 '. Some step failed.'
                                          ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  echo 'Error code' $EC 'received during' "$1" '. Some step failed.'

For more information:
  https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
  https://www.shellcheck.net/wiki/SC2034 -- DOTNET_RUNTIME appears unused. Ve...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...