meshy / django-conman

NOT READY: Work in progress. A content management system for django
BSD 2-Clause "Simplified" License
3 stars 5 forks source link

Test for import order errors with flake8 #22

Closed meshy closed 10 years ago

mlen108 commented 10 years ago

FYI flake8-import-order does not install flake8.

meshy commented 10 years ago

So it doesn't! Thanks!

I've also not managed to get it to use the same order rules we tend to use. This is the closest it gets. What do you think? Is the ability to automate checking it worth changing how we do it?

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 543ca83654444ac8dfecdea094372a6d2c1cb1a1 on flake8-imports into cd105eed09cf3485fdcad54429105688b94c946a on master.

meshy commented 10 years ago

FWIW, I don't object to changing our import order across the board for this -- it seems ok to me.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling e15b4bc20200daf21b5f355ee28f8afe524de573 on flake8-imports into cd105eed09cf3485fdcad54429105688b94c946a on master.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling dad305bb77293978a5eacd95fb759cb1ed4fe1c4 on flake8-imports into cd105eed09cf3485fdcad54429105688b94c946a on master.