Cms - Githubissues

meshy / django-conman

NOT READY: Work in progress. A content management system for django

BSD 2-Clause "Simplified" License

3 stars 5 forks source link

Cms #25

Closed meshy closed 10 years ago

coveralls commented 10 years ago

Coverage remained the same when pulling 8464f9903c5e9f672addee5bd82f7aa2cfed832d on cms into accdec8bbc6094a4de37782d4c0596db60a4a5f2 on master.

meshy commented 10 years ago

nav_tree.urls need integration tests, and cms.urls needs unit tests.

meshy commented 10 years ago

This PR too big -- will have to remove the nav_tree stuff for the moment

coveralls commented 10 years ago

Coverage remained the same when pulling d35c0d58f624ad1357219e6c50c94c52f027b15b on cms into accdec8bbc6094a4de37782d4c0596db60a4a5f2 on master.

coveralls commented 10 years ago

Coverage decreased (-0.56%) when pulling e00a42b9841698c6887a1a8842efa258555b945a on cms into accdec8bbc6094a4de37782d4c0596db60a4a5f2 on master.

kevinetienne commented 10 years ago

Looks good, do you think it worth adding a test for app_url in cms/urls?

meshy commented 10 years ago

Yeah, definitely. I've got a half-built test at home, so I'll commit it tonight

Thanks for having a look :)

meshy commented 10 years ago

(Don't want to lose that 100% coverage!)

coveralls commented 10 years ago

Coverage remained the same when pulling 8445d491030be7fb2fa1175140a4b022b2690425 on cms into accdec8bbc6094a4de37782d4c0596db60a4a5f2 on master.

meshy commented 10 years ago

Please review!

meshy commented 10 years ago

Thank you! :)