search

meshy / django-conman

NOT READY: Work in progress. A content management system for django
BSD 2-Clause "Simplified" License
3 stars 5 forks source link

Update for django 1.8 #44

Closed meshy closed 9 years ago

meshy commented 9 years ago

There's a failing test related to testing the fields on Route. In django 1.8 we seem to be getting the related names of models that were created in other test methods.

kevinetienne commented 9 years ago

I was thinking that Django might have a method to query the non-related fields and related fields separately which might have helped here but I didn't find anything relevant here.

meshy commented 9 years ago

I think that ._meta.get_all_field_names() is deprecated, so we should perhaps replace it with something in incuna-test-utils.

meshy commented 9 years ago

That said, I can't help but question the use of the test now.

LilyFoote commented 9 years ago

Perhaps field_names is appropriate here?

meshy commented 9 years ago

Sounds like a plan.

meshy commented 9 years ago

Alternatively, is there a better way to create the subclasses we're testing?

meshy commented 9 years ago

@Ian-Foote field_names returned a very similar list of fields, and did include the two that are making the tests fail.

LilyFoote commented 9 years ago

Ah, that's a pity.

meshy commented 9 years ago

I added the new fields to what the test expected.

meshy commented 9 years ago

\o/