search

meshy / django-conman

NOT READY: Work in progress. A content management system for django
BSD 2-Clause "Simplified" License
3 stars 5 forks source link

500 when saving a Route with misconfigured parent / slug #62

Closed meshy closed 8 years ago

meshy commented 9 years ago

When a route is saved in the admin with an invalid combination of parent and slug, a 500 is raised. This needs proper validation.

parent no parent
slug branch / leaf node invalid
no slug invalid root node

screenshot from 2015-08-02 15-33-39

Perhaps the message could be clearer too?

meshy commented 9 years ago

It looks as though the validation that exists here can be moved from save to clean and should raise ValidationError rather than ValueError.

meshy commented 8 years ago

Closing in favour of #75